Bukkit
  1. Bukkit
  2. BUKKIT-464

server.broadcast sends messages to players when provided Permission is false.

    Details

    • CB Version String:
      git-Bukkit-1.0.1-R1-13-ga0124aa-b1612jnks (MC: 1.0.1) (Implementing API version 1.0.1-R2-SNAPSHOT)
    • Confirmation Status:
      Unconfirmed

      Description

      server.broadcast at the moment does not appear to check if a permission is true or false before sending the message. This leads to a situation where it is sending messages to players that should otherwise not be receiving them.

      The documentation at the moment is vague about whether this is intended or not, stating that it sends messages to players who have a given permission, however I can't imagine that this is the intended behaviour.

      Steps to reproduce:
      1) Grant a permission node to all players by default
      2) Set the permission to false
      3) Send a message to all players with that permission node

      Expected outcome:

      Only players who have the permission node set to true should receive the message.

      Actual outcome:

      All players will receive the message.

        Activity

        Hide
        James Richardson added a comment -

        I have made a pull request that fixes this issue on GitHub:

        https://github.com/Bukkit/CraftBukkit/pull/614

        Show
        James Richardson added a comment - I have made a pull request that fixes this issue on GitHub: https://github.com/Bukkit/CraftBukkit/pull/614

          People

          • Assignee:
            Unassigned
            Reporter:
            James Richardson
            Participants:
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: