Uploaded image for project: 'Bukkit'
  1. Bukkit
  2. BUKKIT-3505

Ability to distinguish normal damage between damage that has been dealt by the new thorns enchantment

    Details

    • CB Version String:
      This server is running CraftBukkit version git-Bukkit-1.4.7-R0.1 -12-gd9ff553-b2612jnks (MC: 1.4.7) (Implementing API version 1.4.7-R0.2-SNAPSHOT

      Description

      The current BukkitAPI has no possibility to distinguish "normal" damage between damage that has been dealt by thorns. So I would like to request a addition that allows us to distinguish them with the BukkitAPI.

      http://www.minecraftwiki.net/wiki/Enchanting

        Gliffy Diagrams

          Activity

          Hide
          riking Kane York added a comment -

          There are two ways to do this - first, to have CraftEventFactory check the translation string (not recommended). Second is to modify NMS.EnchantmentThorns.a(Entity,EntityLiving,Random) to call the event, which would require adding it to CraftBukkit (not recommended). The third way is to change EntityHuman,Arrow,and Monster to call the event.

          Show
          riking Kane York added a comment - There are two ways to do this - first, to have CraftEventFactory check the translation string (not recommended). Second is to modify NMS.EnchantmentThorns.a(Entity,EntityLiving,Random) to call the event, which would require adding it to CraftBukkit (not recommended). The third way is to change EntityHuman,Arrow,and Monster to call the event.
          Hide
          mypictures MyPictures added a comment -

          One of your commits would have been enough to do the trick Kane but for some reason I cant find them anymore.

          Show
          mypictures MyPictures added a comment - One of your commits would have been enough to do the trick Kane but for some reason I cant find them anymore.
          Show
          riking Kane York added a comment - @MyPictures CB/A: https://github.com/Bukkit/CraftBukkit/pull/1035 CB/B: https://github.com/Bukkit/CraftBukkit/pull/1036 Bukkit: https://github.com/Bukkit/Bukkit/pull/776/files

            People

            • Votes:
              52 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: